Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VMergeBuffer): uopFinish should not be set when redirect #3924

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

Anzooooo
Copy link
Member

If uopFinish is set when redirecting, it may cause incorrect dequeuing and enqueuing conflicts, which may cause allocated to be unable to be set correctly.

@Anzooooo Anzooooo added cherry-pick needed This pull request needs to be cherry-picked to master bug Confirmed bugs and removed bug Confirmed bugs labels Nov 25, 2024
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 5d895a5

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
5d895a5 1.917 0.450 2.701 1.230 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
9c13e96
16534be 0.450 2.701 1.228 2.398 0.921 1.430 2.069 3.437 2.716 3.261
b34797b 1.917 0.450 2.701 1.226 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261
3dfb64b 1.917 0.450 2.701 1.228 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261
96e3f6c 1.917 0.450 2.701 1.226 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261

@linjuanZ linjuanZ merged commit d876189 into master Nov 26, 2024
9 checks passed
@linjuanZ linjuanZ deleted the fix-vmb-cancel branch November 26, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick needed This pull request needs to be cherry-picked to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants